Skip to content

Record Github Auth in Session when Successful #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianwarsing merged 1 commit into from
Apr 29, 2025
Merged

Record Github Auth in Session when Successful #1400

brianwarsing merged 1 commit into from
Apr 29, 2025

Conversation

@brianwarsing
Copy link
Contributor

@brianwarsing brianwarsing commented Apr 28, 2025

Changes

  • Added session[:authenticated] = true in the GitHub authentication callback
  • Added test coverage to verify this behaviour

Testing

  • Added test assertion to verify session[:authenticated] is set correctly
  • Existing authentication flow tests continue to pass

@brianwarsing brianwarsing merged commit 3396b76 into Shopify:main Apr 29, 2025
7 checks passed
@brianwarsing brianwarsing deleted the record_github_auth_in_session branch April 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ginja Ginja Ginja approved these changes

+1 more reviewer

@casperisfine casperisfine casperisfine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianwarsing @Ginja @casperisfine