Skip to content

Fix commit status #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hurracrane merged 1 commit into from
Sep 26, 2025
Merged

Fix commit status #1424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/views/shipit/commits/_commit.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
<%= render 'shipit/shared/author', author: commit.author %>
<% end %>

<%= render 'shipit/statuses/status', status: commit.status %>
<% if commit.status.group? %>
<%= render 'shipit/statuses/group', group: commit.status %>
<% else %>
<%= render 'shipit/statuses/status', status: commit.status %>
<% end %>
Comment on lines +7 to +11
Copy link
Contributor

@timothysmith0609 timothysmith0609 Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we still need to_partial_path on Shipit::Status::Group|Missing|Unknown since we are explicitly calling out the partials now? (Not blocking)

Copy link
Contributor Author

@hurracrane hurracrane Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may opt to follow up with a change to address this.

<div class="commit-details">
<span class="commit-title"><%= render_commit_message_with_link commit %></span>
<p class="commit-meta">
Expand Down