Refactor paginated_check_runs to use lazy pagination#1436
Merged
Conversation
b0a1a7a to
36a0841
Compare
36a0841 to
2996d7b
Compare
timothysmith0609
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
RefreshCheckRunsJobrefreshes all checks associated with a particular commit viarefresh_check_runs!. That method relies onpaginated_check_runs, which currently loads all paginated results into memory before processing them. This can result in memory bloat for commits with a large number of check runs (e.g., hundreds of check runs across multiple pages).Changes
This PR updates
paginated_check_runsto process each page lazily by yielding batches to the caller as they're fetched, rather than accumulating all results in memory first.Testing
This also adds test coverage for the pagination case, as existing test coverage only handled single-page responses.