Merge pull request #1288 from Shopify/fix_deprecated-error-not-having-message

Fix FeatureDeprecatedError being raised without a message

Author: paulomarg

CHANGELOG.md

@@ -4,6 +4,8 @@ Note: For changes to the API, see https://shopify.dev/changelog?filter=api
 
 ## Unreleased
 
+- [#1288](https://github.com/Shopify/shopify-api-ruby/pull/1288) Fix FeatureDeprecatedError being raised without a message.
+
 ## 14.0.0
 - [#1274](https://github.com/Shopify/shopify-api-ruby/pull/1274) ⚠️ [Breaking] Update sorbet and rbi dependencies. Remove support for ruby 2.7. Minimum required Ruby version is 3.0
 - [#1282](https://github.com/Shopify/shopify-api-ruby/pull/1282) Fixes a bug where diffing attributes to update not take into account of Array changes and required ids.

lib/shopify_api/logger.rb

@@ -33,7 +33,7 @@ def error(message)
       def deprecated(message, version)
         return unless enabled_for_log_level?(:warn)
 
-        raise Errors::FeatureDeprecatedError unless valid_version(version)
+        raise Errors::FeatureDeprecatedError, message unless valid_version(version)
 
         send_to_logger(:warn, message)
       end

test/logger_test.rb

@@ -8,9 +8,11 @@ class LoggerTest < Minitest::Test
     def test_deprecated_should_raise_an_error_if_version_is_lower_or_equal_to_current
       ShopifyAPI::Context.stubs(:log_level).returns(:warn)
 
-      assert_raises(ShopifyAPI::Errors::FeatureDeprecatedError) do
+      error = assert_raises(ShopifyAPI::Errors::FeatureDeprecatedError) do
         ShopifyAPI::Logger.deprecated("deprecated feature", ShopifyAPI::VERSION)
       end
+
+      assert_equal("deprecated feature", error.message)
     end
 
     def test_logging_with_log_levels