Skip to content

Update oauth logic to account for new admin-web url #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizkenyon merged 3 commits into from
Aug 14, 2025
Merged

Update oauth logic to account for new admin-web url #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55fb21f
Update oauth logic to account for new admin-web url
jecepeda Aug 14, 2025
db56527
Use nonstandard_host_prefix
jecepeda Aug 14, 2025
6091abb
Reflect new changes in CHANGELOG.md
jecepeda Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Note: For changes to the API, see https://shopify.dev/changelog?filter=api
## Unreleased
- [#1395](https://github.com/Shopify/shopify-api-ruby/pull/1395) use correct internal admin host for 1P app development

## 14.11.0
- [#1386](https://github.com/Shopify/shopify-api-ruby/pull/1386) Add support for 2025-07 API version
Expand Down
3 changes: 2 additions & 1 deletion lib/shopify_api/auth/oauth.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ def auth_base_uri(shop)
return "https://#{shop}/admin" unless defined?(DevServer) && shop.include?(".my.shop.dev")

# For first-party apps in development only, we leverage DevServer to build the admin base URI
admin_web = T.unsafe(Object.const_get("DevServer")).new("web") # rubocop:disable Sorbet/ConstantsFromStrings
admin_web = T.unsafe(Object.const_get("DevServer")) # rubocop:disable Sorbet/ConstantsFromStrings
.new("admin-web")
admin_host = admin_web.host!(nonstandard_host_prefix: "admin")
shop_name = shop.split(".").first

Expand Down