Skip to content

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented May 6, 2025

JS shim of #1043

This cannot be generated with the action at this point in time as the public/app-bridge-ui-experimental.js fails eslint which will get removed after the new Admin UI Foundations release includes https://github.com/Shopify/admin-ui-foundations/pull/2773

To generate this PR

1: Make a branch off https://github.com/Shopify/admin-ui-foundations/pull/2773

2: Create a tsconfig.js.json with:

{
  "include": ["./app/**/*", "*.ts", "*.tsx", ".graphqlrc.ts"],
  "compilerOptions": {
    "strict": true,
    "removeComments": false,
    "skipLibCheck": true,
    "isolatedModules": true,
    "noEmitOnError": true,
    "jsx": "preserve",
    "module": "ES2022",
    "moduleResolution": "bundler",
    "target": "ES2022",
    "paths": {
      "~/*": ["./app/*"]
    }
  }
}

3: Run yarn tsc -p tsconfig.js.json

4: Delete the typescript files

find app \( -name "*.ts" -o -name "*.tsx" \) -delete
find . \( -name ".graphqlrc.ts" -o -name "tsconfig.js.json" -o -name "vite.config.ts" \) -delete

5: Format the generated js files yarn prettier -w "app/**/*.{js,jsx}" ".graphqlrc.js" "vite.config.js"

<s-stack direction="inline" gap="base">
<s-button
onClick={generateProduct}
{...(isLoading ? { loading: true } : {})}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyledurand did you confirm this was needed?

@alex-page alex-page changed the title test Polaris Web Component JavaScript template [Do not merge until GA] Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants