Remove duplicate scrpt tags #1110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
reviewed
Jul 10, 2025
Comment on lines
-30
to
-31
| <script src="https://cdn.shopify.com/shopifycloud/app-bridge.js"></script> | ||
| <script src="https://cdn.shopify.com/shopifycloud/app-bridge-ui-experimental.js"></script> |
There was a problem hiding this comment.
The other location also needs the app-bridge.js file. Currently it only has the app-bridge-ui-experimental.js
There was a problem hiding this comment.
No, I don't think it does?
This page is rendered outside of the iFrame. We want to it to look like the admin, but not redirect to the admin. IF we include App Bridge it will fail because we dont know how to configure it on this page.
There was a problem hiding this comment.
I am confused. I just expect to see those two scripts available to developers inside the iframe. After this PR ships there won't be an app-bridge.js file which is incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were including these script tags in 2 places on the page. We only ned them once