Update to latest version of Shopify Packages && Drop Node 18 #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizkenyon
force-pushed
the
v4-shopify-app-remix
branch
from
fce995b to
e4985d8
Compare
lizkenyon
force-pushed
the
v4-shopify-app-remix
branch
from
e4985d8 to
26bbd64
Compare
lizkenyon
changed the title
byrichardpowell
approved these changes
Sep 17, 2025
byrichardpowell
approved these changes
Sep 17, 2025
Contributor
byrichardpowell
left a comment
byrichardpowell
left a comment
There was a problem hiding this comment.
Approving so you can merge without a 2nd review, but just one commnt
| "type": "module", | ||
| "engines": { | ||
| "node": "^18.20 || ^20.10 || >=21.0.0" | ||
| "node": "^20.10 || >=21.0.0" |
Contributor
There was a problem hiding this comment.
Can this simply be >=20.10.0 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Test this PR
Checklist
README.mdfile and other related documentation, if applicableCHANGELOG.md