Conversation
a9aefb3 to
f09e915
Compare
Add check for app blocks Add docs Update naming rubo cop rubo cop
7ef47f6 to
7aafea2
Compare
5 tasks
sle-c
reviewed
Mar 11, 2025
24c114b to
75cde50
Compare
75cde50 to
385d1e6
Compare
sle-c
approved these changes
Mar 13, 2025
Contributor
sle-c
left a comment
There was a problem hiding this comment.
some minor comments, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the a script tag manager to the
shopify_appgem.This functionality was removed in version 22 of this package.
Script tags are still a valid way for modify the content of vintage themes.
This PR has several differences between the previous script tag manager
scripttag_managertoscript_tag_managerscript_tag-720.mov
Reviewer's guide to testing
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary