Support Shopify storefront domain in development#1957
Closed
Conversation
yao0204
approved these changes
Mar 24, 2025
lizkenyon
approved these changes
Mar 25, 2025
Contributor
lizkenyon
left a comment
lizkenyon
left a comment
There was a problem hiding this comment.
👍 Looks good.
Approving but can you remove the version changes?
I will do that in a separate PR, when I update the migration guide ect.
|
Just wondering, why this Pr is not merged yet? |
Contributor
Author
|
Closing this issue since this isn't needed anymore to solve the matter (see https://github.com/Shopify/shop-server/issues/101259#issuecomment-2761891469). Thanks for your attention @lizkenyon! |
|
our app ran into the same problem, but because we are sunsetting it soon, and our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Shopify recently changed their internal domains in development. In this PR, we update the URI sanitation to globally substitute storefront domains with internal domains and enable the installation of Shopify Apps.
We are okay to expose this logic publicly as per https://github.com/shop/world/pull/18779#discussion_r2003371745.
Reviewer's guide to testing
Follow the instructions in https://shop.docs.shopify.io/docs/shop-server/architecture/components/merchant/local to install an app in development, using the code from https://github.com/Shopify/shop-server/pull/100230 and https://github.com/shop/world/pull/18779. Given the gem is unreleased, update shop-server to point to this branch.
Things to focus on
App installation setup should work in development.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary