Skip to content

[Breaking] Security bump nokogiri gem to latest 1.18.5#1958

Merged
lizkenyon merged 2 commits intomainfrom
security-bump-nokogiri
Mar 25, 2025
Merged

[Breaking] Security bump nokogiri gem to latest 1.18.5#1958
lizkenyon merged 2 commits intomainfrom
security-bump-nokogiri

Conversation

@Shinomix
Copy link
Contributor

What this PR does

In this PR we bump nokogiri to the latest version in order to close security issues https://github.com/Shopify/shopify_app/security/dependabot/164 and https://github.com/Shopify/shopify_app/security/dependabot/157 and be able to release new gem versions.

Reviewer's guide to testing

Nokogiri changelog does not contain breaking changes. This change should be transparent.

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@Shinomix Shinomix requested a review from lizkenyon March 24, 2025 13:34
@Shinomix Shinomix requested a review from a team as a code owner March 24, 2025 13:34
@Shinomix
Copy link
Contributor Author

Shinomix commented Mar 24, 2025

@lizkenyon Nokigiri~18.0.0 drops support for Rails 3.0 which this gem still supports. Unfortunately, they don't maintain 2 releases tracks as some gems do, so we have to bump to the latest to fix the CVEs.

Either we can't release our gem because of dependabot or we drop support for rails 3.0. For the latter, we'll need to do a major version bump with a breaking change for our gem.

@Shinomix Shinomix changed the title Security bump nokogiri gem to latest 1.18.5 [Breaking] Security bump nokogiri gem to latest 1.18.5 Mar 25, 2025
@lizkenyon lizkenyon merged commit 50a3dd5 into main Mar 25, 2025
6 of 7 checks passed
@lizkenyon lizkenyon deleted the security-bump-nokogiri branch March 25, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants