[Breaking] Security bump nokogiri gem to latest 1.18.5#1958
Merged
Conversation
Contributor
Author
|
@lizkenyon Nokigiri~18.0.0 drops support for Rails 3.0 which this gem still supports. Unfortunately, they don't maintain 2 releases tracks as some gems do, so we have to bump to the latest to fix the CVEs. Either we can't release our gem because of dependabot or we drop support for rails 3.0. For the latter, we'll need to do a major version bump with a breaking change for our gem. |
4 tasks
lizkenyon
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR we bump nokogiri to the latest version in order to close security issues https://github.com/Shopify/shopify_app/security/dependabot/164 and https://github.com/Shopify/shopify_app/security/dependabot/157 and be able to release new gem versions.
Reviewer's guide to testing
Nokogiri changelog does not contain breaking changes. This change should be transparent.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary