include app-bridge asset in the script-src csp directive#1995
Closed
fresh-eggs wants to merge 1 commit intomainfrom
Closed
include app-bridge asset in the script-src csp directive#1995fresh-eggs wants to merge 1 commit intomainfrom
fresh-eggs wants to merge 1 commit intomainfrom
Conversation
b8728b3 to
1a232ea
Compare
1a232ea to
7d6b8a7
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This gem requires an asset that is hosed on
cdn.shopify.com:For applications that enforce a strict ContentSecurityPolicy, the asset is unlikely to be listed as a permitted script-src .
Rails offers controller APIs to add per-request exceptions to a global policy.
Applications could add exceptions to the controllers included by this gem but it would be best if the gem includes them itself. (similar pattern in maintenance_tasks gem)
Reviewer's guide to testing
This change ensures that the script-src directive on the
ContentSecurityPolicyresponse header served by this gem's controllers include the additional value:Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary