Use ENV.fetch to get HOST instead of relying on useless Sorbet error#1998
Open
sshaw wants to merge 1 commit intoShopify:mainfrom
Open
Use ENV.fetch to get HOST instead of relying on useless Sorbet error#1998sshaw wants to merge 1 commit intoShopify:mainfrom
sshaw wants to merge 1 commit intoShopify:mainfrom
Conversation
The auto-generated initializer has various starting time checks to prevent app misconfiguration before running. This did not apply to ShopifyAPI::Context's host: keyword. If the HOST env var was not present, a unhelpful "TypeError (Passed `nil` into T.must)" error was raised by Sorbet. Now if there is no HOST env var present, the app will fail to run, like it does with other checks, and the user will receive a helpful message.
sshaw
commented
Sep 19, 2025
| api_secret_key: ShopifyApp.configuration.secret, | ||
| api_version: ShopifyApp.configuration.api_version, | ||
| host: ENV['HOST'], | ||
| host: ENV.fetch('HOST'), |
Contributor
Author
There was a problem hiding this comment.
Maybe this is only a 90% improvement because what does Sorbet regurgitate when it's an empty string? A good ol user-raised ArgumentError or TypeError with a nice message is best but, this is quick and simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The auto-generated initializer has various starting time checks to prevent app misconfiguration before running. This did not apply to ShopifyAPI::Context's host: keyword. If the HOST env var was not present, a unhelpful "TypeError (Passed
nilinto T.must)" error was raised by Sorbet. Now if there is no HOST env var present, the app will fail to run, like it does with other checks, and the user will receive a helpful message.As mentioned in #1710 and #1526
Sorbet 🤮
Reviewer's guide to testing
Things to focus on
In generated project:
config/inititalizers/shopify_app.rbChecklist
Before submitting the PR, please consider if any of the following are needed:
This should be done by the maintainer at release time, not by contributors.