Allow custom handler to be passed when registering a webhook#2014
Closed
Allow custom handler to be passed when registering a webhook#2014
Conversation
96b6eb4 to
cddb6c9
Compare
Author
|
Arg. I just realized that you cannot register a http webhook in the WebhookRegistry without a handler: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When an app uses a custom WebhooksController instead of using the Gem provided WebhooksController, the app assumes responsibility for receiving and processing web hook requests, and thus does not need to register ActiveJob
handlerswhich match the name of the webhook's topic as required by WebhooksController.There is a bug in
WebhookManagerwhich requires the app to maintain an ActiveJob class matching the name of the topic even if the app uses a custom WebhooksController.In this Pull Request, I add an additional
WebhookManagerwebhooks configuration property calledhandlerwhich is the name of the ActiveJob class to enqueue if using the default WebhooksController ornilto unset thehandler. The latter feature - the ability to sethandler: nilwill fix the bug.Reviewer's guide to testing
Because this introduces a new configuration property but maintains backward compatibility with current configuration (not setting the
handlerproperty behaves exactly the same), I rely on unit tests to assert the change.Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary