Skip to content

Conversation

@kirillplatonov
Copy link
Contributor

@kirillplatonov kirillplatonov commented Dec 18, 2025

What this PR does

Rails 7.1+ no longer provides public method ActiveSupport::Deprecation.warn.

➜  color-swatches git:(main) ✗ bin/rails test
/Users/kirill/.local/share/mise/installs/ruby/3.4.5/lib/ruby/gems/3.4.0/gems/shopify_app-23.0.0/lib/shopify_app/logger.rb:11:in 
'ShopifyApp::Logger.deprecated': private method 'warn' called for class ActiveSupport::Deprecation (NoMethodError)

        ActiveSupport::Deprecation.warn("[#{version}] #{context(:warn)} #{message}")
                                  ^^^^^

This PR switches to the use of instance of ActiveSupport::Deprecation. to resolve the issue.

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@kirillplatonov kirillplatonov requested a review from a team as a code owner December 18, 2025 16:32
deprecator.warn("[#{version}] #{context(:warn)} #{message}")
end

def deprecator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mark this as private for consistency with the other helper methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated

@lizkenyon
Copy link
Contributor

Thanks for your contributions here!

I will release these changes on Monday.

@lizkenyon lizkenyon merged commit d4c3cd2 into Shopify:main Dec 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants