Fix deprecation warnings for Rails 7.1+#2041
Merged
lizkenyon merged 4 commits intoShopify:mainfrom Dec 22, 2025
Merged
Conversation
lizkenyon
approved these changes
Dec 18, 2025
| deprecator.warn("[#{version}] #{context(:warn)} #{message}") | ||
| end | ||
|
|
||
| def deprecator |
Contributor
There was a problem hiding this comment.
Let's mark this as private for consistency with the other helper methods
Contributor
Author
There was a problem hiding this comment.
Sure, updated
Contributor
|
Thanks for your contributions here! I will release these changes on Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Rails 7.1+ no longer provides public method
ActiveSupport::Deprecation.warn.This PR switches to the use of instance of
ActiveSupport::Deprecation.to resolve the issue.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary