[patch] Fix TypeError in webhook job templates with shopify_api >= 16.0.0 #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblock users experiencing TypeError when registering webhook handlers due to Sorbet type checking introduced in shopify_api-16.0.0 Changed to for ShopifyAPI::Webhooks::WebhookHandler in all webhook job templates. This makes the class object itself satisfy the WebhookHandler type expected by WebhooksManager.add_registrations Affected templates: - app_uninstalled_job.rb.tt - customers_data_request_job.rb.tt - customers_redact_job.rb.tt - shop_redact_job.rb.tt - webhook_job.rb.tt
byrichardpowell
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblock users experiencing TypeError when registering webhook handlers due to Sorbet type checking introduced in shopify_api-16.0.0
Changed to for ShopifyAPI::Webhooks::WebhookHandler in all webhook job templates. This makes the class object itself satisfy the WebhookHandler type expected by
WebhooksManager.add_registrations
Affected templates:
What this PR does
Reviewer's guide to testing
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary