Use static names for anonymous parameters#811
Draft
thomasmarshall wants to merge 1 commit intoko/rbs-over-prismfrom
Draft
Use static names for anonymous parameters#811thomasmarshall wants to merge 1 commit intoko/rbs-over-prismfrom
thomasmarshall wants to merge 1 commit intoko/rbs-over-prismfrom
Conversation
amomchilov
reviewed
Dec 15, 2025
amomchilov
approved these changes
Dec 15, 2025
The original RBS rewriter runs after the parser has assigned unique names to anonymous parameters, which it can then pull out of the method definition. With the Prism RBS rewriter, we can't generate unique names until later on when the translator is run. We can use static names instead as `*`, `**`, and `&` are guaranteed to be unique anyway (in fact this is already the case for the block param).
thomasmarshall
force-pushed
the
anonymous-parameter-names
branch
from
a5d8cac to
0af67b9
Compare
KaanOzkan
force-pushed
the
ko/rbs-over-prism
branch
from
ac9397b to
cafe258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original RBS rewriter runs after the parser has assigned unique names to anonymous parameters, which it can then pull out of the method definition. With the Prism RBS rewriter, we can't generate unique names until later on when the translator is run. We can use static names instead as
*,**, and&are guaranteed to be unique anyway (in fact this is already the case for the rest param).