Remove verify_prism_regression_tests.sh#826

Open

thomasmarshall wants to merge 217 commits intodesugar-remainingfrom

remove-verify-prism-script

Commits on Nov 10, 2025

Fix lambda `Send` locations
amomchilov
committed

Commits on Nov 12, 2025

Fix Regexp desugared content location
amomchilov
committed

Commits on Dec 3, 2025

Add fallback to legacy pipeline

amomchilov
and
jesse-shopify
committed

Commits on Dec 8, 2025

Commits on Dec 9, 2025

Commits on Dec 10, 2025

Match Whitequark based desugar of call node when both forwarding and block literal are present

jesse-shopify
authored and
amomchilov
committed
Match legacy desugar of call with block pass a block literal

jesse-shopify
authored and
amomchilov
committed
Update error handling file enumeration of issues

jesse-shopify
authored and
amomchilov
committed
Compare NameRefs instead of strings
amomchilov
committed
Move receiver handling up
amomchilov
committed
Rename `messageLoc` → `methodNameLoc`
amomchilov
committed
Lift `isPrivateOk` local
amomchilov
committed
Additional testing for call node forwarding error cases

jesse-shopify
authored and
amomchilov
committed
Extract `desugarBlock()`
amomchilov
committed
Lift `block` desugaring up
amomchilov
committed
Align location of flattenKwargs to whitequark ouput

jesse-shopify
authored and
amomchilov
committed
Add tests for call forwarding variations in error recovery

jesse-shopify
authored and
amomchilov
committed
Lift out `argumentsNode` local
amomchilov
committed
Reuse `receiverNode` local
amomchilov
committed
Migrate `computeMethodCallLoc()` block param
amomchilov
committed
Lift `block_given?` check up
amomchilov
committed
Align PM_LAMBDA_NODE location with legacy desugar

jesse-shopify
authored and
amomchilov
committed
align PM_SUPER_NODE with legacy desugar locations

jesse-shopify
authored and
amomchilov
committed
Exclude prism regression tests related to error recovery from prism_regression for now

jesse-shopify
authored and
amomchilov
committed
Align parens handling with legacy desugar for PM_MULTI_TARGET_NODE

jesse-shopify
authored and
amomchilov
committed
document excludes in prism_regression tests

jesse-shopify
authored and
amomchilov
committed
More loaction updates for PM_FOR_LOOP and call forwarding

jesse-shopify
authored and
amomchilov
committed
Additional location update to match existing behavior

jesse-shopify
authored and
amomchilov
committed
Better document prism exclusions

jesse-shopify
authored and
amomchilov
committed
Restore disable-parser-comparison flags

jesse-shopify
authored and
amomchilov
committed
Update PM_CASE_NODE locations to match legacy when "when body" is empty

jesse-shopify
authored and
amomchilov
committed

Commits on Dec 11, 2025

more sophisticated PM_CASE_NODE location fix

jesse-shopify
authored and
amomchilov
committed
Fix heredoc locations

jesse-shopify
authored and
amomchilov
committed
Fix issues following rebase

jesse-shopify
authored and
amomchilov
committed
refactor desugarMlhs to fix tests and improve code

jesse-shopify
authored and
amomchilov
committed
Align string / HEREDOC locations

jesse-shopify
authored and
amomchilov
committed
Align with whitequark on locations of PM_CASE_NODE and PM_IT_PARAMETERS_NODE

jesse-shopify
authored and
amomchilov
committed

Commits on Dec 12, 2025

disable-parser-comparison on additional prism_regression tests

jesse-shopify
authored and
amomchilov
committed
exclude more files from test_corpus_prism

jesse-shopify
authored and
amomchilov
committed

Commits on Dec 16, 2025

Commits on Dec 19, 2025

Throw `PrismFallback` in unimplemented code paths
amomchilov
committed
Narrow type of `make_node_with_expr()`
amomchilov
committed
Delete most of `PrismDesugar.cc`

amomchilov
and
thomasmarshall
committed
Delete `directDesugar` dead code

amomchilov
and
jesse-shopify
committed
Narrow type of `make_unsupported_node()`
amomchilov
committed
Make `make_node_with_expr()` static
amomchilov
committed
Delete `directlyDesugar` checks

amomchilov
and
jesse-shopify
committed
Delete remaining `directlyDesugar` uses

amomchilov
and
jesse-shopify
committed
Rework `hasExpr()` into `enforceHasExpr`

amomchilov
and
jesse-shopify
committed
Delete `hasExpr()`

amomchilov
and
jesse-shopify
committed
Migrate `desugarScopeBodyToRHSStore` to non-optional

amomchilov
and
jesse-shopify
committed
Delete always-true check
amomchilov
committed
Add new `ExprOnly` wrapper node

amomchilov
and
thomasmarshall
committed
Add `desugar()` methods
amomchilov
committed
Merge translate+desugar for Hash nodes
amomchilov
committed
Update translateRegexp to return expr_only

amomchilov
and
thomasmarshall
committed
Update translateRegexpOptions to return expr_only

jesse-shopify
and
amomchilov
committed
PM_ALIAS_GLOBAL_VARIABLE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
Migrate to `expr_only`

jesse-shopify
authored and
amomchilov
committed
PM_INTERPOLATED_SYMBOL_NODE, PM_INTERPOLATED_X_STRING_NODE, PM_INTERPOLATED_STRING_NODE, PM_INTERPOLATED_REGULAR_EXPRESSION_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_IMAGINARY_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_RANGE_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
PM_WHILE_NODE, PM_UNTIL_NODE return expr_only

jesse-shopify
authored and
amomchilov
committed
add desugarBreakNextReturn to handle those cases add desugarArguments helper PM_BREAK_NODE, PM_NEXT_NODE, PM_RETURN_NODE are refactored to called to desugarBreakNextReturn and return expr_only

committed
PM_YIELD_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_X_STRING_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_INDEX_TARGET_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_ARRAY_NODE returns expr_only

authored and
amomchilov
committed
Replace `desugarArguments()` with `nodeListToStore()`

jesse-shopify
authored and
amomchilov
committed
PM_UNDEF_NODE returns expr_only

authored and
amomchilov
committed
PM_EMBEDDED_STATEMENTS_NODE returns expr_only

authored and
amomchilov
committed
PM_PARENTHESES_NODE returns expr_only

authored and
amomchilov
committed
PM_STATEMENTS_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
Use takeDesugaredExprOrEmptyTree where possible

jesse-shopify
authored and
amomchilov
committed
Allow specifying location for empty tree ExprOnly

thomasmarshall
authored and
amomchilov
committed
Fix location for empty regexps

thomasmarshall
authored and
amomchilov
committed
Translate begin node inside method context

thomasmarshall
authored and
amomchilov
committed
Reorder rescue case temp name to match original parser

thomasmarshall
authored and
amomchilov
committed
Add missing parse-tree exp

thomasmarshall
authored and
amomchilov
committed
PM_BEGIN_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_FORWARDING_SUPER_BLOCK returns expr_only partly

jesse-shopify
authored and
amomchilov
committed
PM_MULTI_WRITE_NODE returns expr_only partly

jesse-shopify
authored and
amomchilov
committed
PM_RESCUE_MODIFIER_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_SPLAT_NODE returns expr_only

jesse-shopify
authored and
amomchilov
committed
PM_IF_NODE and PM_UNLESS_NODE return expr_only and refactored

jesse-shopify
authored and
amomchilov
committed
Migrate `it` parameters to `expr_only`
amomchilov
committed
desugar Assignment helpers

jesse-shopify
authored and
amomchilov
committed
translateConst use expr_only and narrow return

jesse-shopify
authored and
amomchilov
committed
change interface of translateConst

jesse-shopify
authored and
amomchilov
committed
Remove legacy parser code from PM_CASE_NODE

jesse-shopify
authored and
amomchilov
committed
more removal of legacy parser from PM_CASE_NODE

jesse-shopify
authored and
amomchilov
committed
migrate make_unsupported_node to use expr_only

jesse-shopify
authored and
amomchilov
committed
mark PM_WHEN_NODE as unreachable

jesse-shopify
authored and
amomchilov
committed
Add collectPatternMatchingVarsPrism and update PM_CASE_MATCH_NODE

jesse-shopify
authored and
amomchilov
committed
Additional work on pattern matching to fix tests and handle more cases

jesse-shopify
authored and
amomchilov
committed
Remove legacy parser code from PM_FOR_NODE - part 1

jesse-shopify
authored and
amomchilov
committed
PM_FOR_NODE part 2

jesse-shopify
authored and
amomchilov
committed
PM_FOR_NODE part 3

jesse-shopify
authored and
amomchilov
committed
remove translateStatements

jesse-shopify
authored and
amomchilov
committed
Delete `desugarHash()`
amomchilov
committed
Migrate `desugarScopeBodyToRHSStore()`

amomchilov
and
jesse-shopify
committed
Clean up `this->enterModuleContext()` param

amomchilov
and
jesse-shopify
committed
Rename to `desugarClassOrModule()`

amomchilov
and
jesse-shopify
committed
Migrate bodies of class/sclass/module

amomchilov
and
jesse-shopify
committed
Delete `parser::Send` construction
amomchilov
committed
Remove `kwargsHashHasExpr`
amomchilov
committed
Remove `supportedArgs`
amomchilov
committed
Rework check for `block_given?`
amomchilov
committed
Remove `attemptToDesugarBlockParams`
amomchilov
committed
Narrow `didDesugarBlockParams`
amomchilov
committed
Move `supportedCallType` down
amomchilov
committed
Remove dead branch
amomchilov
committed
Remove `supportedBlock`
amomchilov
committed
Prune dead branches
amomchilov
committed
Remove `supportedCall`
amomchilov
committed
Remove `attemptToDesugarParams`
amomchilov
committed
Remove `parser::DefMethod` construction
amomchilov
committed
Narrow `didDesugarParams`
amomchilov
committed
Bury `didDesugarParams` check into helper
amomchilov
committed
Remove always-true bool return
amomchilov
committed
Remove always-true bool param
amomchilov
committed
Replace `c_all_of()` with loop and eager throw
amomchilov
committed
Invert if-else

amomchilov
and
thomasmarshall
committed
Remove `parser::DefMethod`/`DefS` construction

amomchilov
and
thomasmarshall
committed
Add new `desugarParametersNode()` overload

amomchilov
and
thomasmarshall
committed
Reuse `desugarParametersNode()` for block params

committed
Migrate `it` desugar logic
amomchilov
committed
Delete unused `blockParameters` local

committed
Delete old parameter translation functions

committed
Remove `NodeVec` return

committed
Return `PARAM_store` from helper

committed
Use ExprOnly for `translateOpAssignment()` and co.
amomchilov
committed
Migrate params to `ast::ExpressionPtr`
amomchilov
committed
Migrate `translateAnyOpAssignment()` param
amomchilov
committed
Rename `lhsExpr` → `lhs`
amomchilov
committed
Rename `rhsExpr` → `rhs`
amomchilov
committed
Clean up `translateIndexAssignment()` body
amomchilov
committed
Don't pass block when desugaring index assignement

committed
Delete `translateArguments()`
amomchilov
committed
Narrow `translateIndexAssignment()` return type
amomchilov
committed
Migrate op assigns to return `ExpressionPtr`
amomchilov
committed
Migrate translateRegexp and translateRegexpOptions to return ExpressionPtr

jesse-shopify
authored and
amomchilov
committed
Remove translateMulti and translateMultiInto

jesse-shopify
authored and
amomchilov
committed
Disable prism/legacy pipeline comparison for certain tests

authored and
amomchilov
committed
Extract lambda in desugarMlhs

thomasmarshall
authored and
amomchilov
committed
Pass prism node to desugarMlhs

thomasmarshall
authored and
amomchilov
committed
Use desugar in PM_MULTI_WRITE_NODE

thomasmarshall
authored and
amomchilov
committed
Use desugar in PM_MULTI_TARGET_NODE

thomasmarshall
authored and
amomchilov
committed
Add destructureMlhsParam

thomasmarshall
authored and
amomchilov
committed
Remove intermediate `NodeVec`

amomchilov
and
thomasmarshall
committed
Remove translateMultiTargetLhs

thomasmarshall
authored and
amomchilov
committed
Add tests for parameter destructuring
amomchilov
committed
remove legacy parser from patternTranslate

jesse-shopify
authored and
amomchilov
committed
Remove unreachable guard clause

thomasmarshall
authored and
amomchilov
committed
Fix formatting

thomasmarshall
authored and
amomchilov
committed
fixup! remove legacy parser from patternTranslate

thomasmarshall
authored and
amomchilov
committed
Remove unused helpers

thomasmarshall
authored and
amomchilov
committed
patternTranslate returns ast::ExpressionPtr

jesse-shopify
authored and
amomchilov
committed
remove nodeVecToStore

jesse-shopify
authored and
amomchilov
committed
Delete now-unused overloads of `enforceHasExpr()`
amomchilov
committed
Remove translate followed by enforceHasExpr with desugar / desugarNullable

jesse-shopify
authored and
amomchilov
committed
Delete dead complemented integer edgecase
amomchilov
committed
remove enforceHasExpr from PM_CALL_NODE

jesse-shopify
authored and
amomchilov
committed
remove args NodeVec from PM_CALL_NODE and remaining enforceHasExpr uses

jesse-shopify
authored and
amomchilov
committed
remove legacy parser dependencies in PM_CALL_NODE kwarg handling and flattenKwargs

jesse-shopify
authored and
amomchilov
committed
additional PM_CALL_NODE legacy parser code removal

jesse-shopify
authored and
amomchilov
committed
Desugar PM_KEYWORD_HASH_NODE

thomasmarshall
authored and
amomchilov
committed
Delete `takeDesugaredExprOrEmptyTree()`
amomchilov
committed
Inline last `enforceHasExpr()` helper
amomchilov
committed
Document unreachable cases
amomchilov
committed
Migrate `PM_CASE_MATCH_NODE`'s predicate
amomchilov
committed
Remove dead branch
amomchilov
committed
Move local vars closer to point of use
amomchilov
committed
Remove all but 2 remaining `->takeDesugaredExpr()`
amomchilov
committed
Remove unnecessary `translate()` call
amomchilov
committed
Rename `valueNode` → `argument`
amomchilov
committed
squash! delete stale comment
amomchilov
committed
squash! delete stale comment
amomchilov
committed
Delete `parser::NodeWithExpr`
amomchilov
committed
Remove `expr_only()` calls
amomchilov
committed
Delete `empty_expr()`
amomchilov
committed
Delete `expr_only()`
amomchilov
committed
Migrate `translate()` to `ast::ExpressionPtr`
amomchilov
committed
fixup! document unreachable
amomchilov
committed
silence unused var
amomchilov
committed
fake location
amomchilov
committed
Fix empty else

thomasmarshall
authored and
amomchilov
committed
Direct dispatch to `desugarStatements()`
amomchilov
committed
Rename `translate()` → `desugar()`
amomchilov
committed
Rename `patternTranslate()` → `desugarPattern()`
amomchilov
committed
exclude additional test failures

jesse-shopify
authored and
amomchilov
committed
Set ast/desugar test to manual until SimplePrismDesugar test is fixed

jesse-shopify
authored and
amomchilov
committed

Commits on Jan 7, 2026

Remove verify_prism_regression_tests.sh
thomasmarshall
committed