Closed
Conversation
URI::Source#fragmentURI::Source with RubyLSP
Member
|
The test failures are legit. In our source URIs, the gem version after the name is optional. When it's missing, it indicates whatever version is currently activated in a Bundle context. |
Morriar
reviewed
Jan 6, 2026
|
|
||
| # We need to hide these aliased methods from Sorbet, because it would otherwise complain about these | ||
| # being redefinitions of the existing methods it knows about from RubyLSP. | ||
| self #: as untyped # rubocop:disable Style/RedundantSelf |
Contributor
There was a problem hiding this comment.
Do we still need this since host and fragment are defined in the RBI?
Contributor
Author
There was a problem hiding this comment.
Yes, but for a different reason now. See the comment on lines 29-30
I renamed this class from Tapioca::SourceURI to URI::Source (same as what RubyLSP would define), so these are redefinitions of those methods now
Contributor
There was a problem hiding this comment.
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
d03cd25 to
8a51701
Compare
8a51701 to
cd56d1f
Compare
vinistock
previously approved these changes
Jan 6, 2026
Member
|
Superseded by #2480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Fixes #2471
URI::Source#fragmentalias_methodURI::Sourcewith Tapioca ruby-lsp#3891)delete_prefix("/")in the path parsing code/in theURI::Source#to_soutput