Skip to content

Switch to Package URI for source location comments #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paracycle wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Switch to Package URI for source location comments #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ee69ed
Switch to using Package URL formatted source comments
paracycle Jan 6, 2026
d1d4e23
Regenerate all gem RBI files
paracycle Jan 6, 2026
0f78e5c
Small RBI file updates to compensate for missing constants
paracycle Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ AllCops:
SuggestExtensions: false
Exclude:
- "vendor/**/*"
- "lib/tapioca/helpers/package_url.rb"
Include:
- "sorbet/rbi/shims/**/*.rbi"

Expand Down
11 changes: 6 additions & 5 deletions lib/tapioca/gem/listeners/source_location.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@ def add_source_location_comment(node, file, line)
# we can clear the gem version if the gem is the same one we are processing
version = "" if gem == @pipeline.gem

uri = SourceURI.build(
gem_name: gem.name,
gem_version: version,
path: path.to_s,
line_number: line.to_s,
uri = Tapioca::Helpers::PackageURL.new(
type: "gem",
name: gem.name,
version: version,
subpath: "#{path}:#{line}",
)

node.comments << RBI::Comment.new("") if node.comments.any?
node.comments << RBI::Comment.new(uri.to_s)
rescue URI::InvalidComponentError, URI::InvalidURIError
Expand Down
Loading
Loading