Fix missing gem specs test #2484
Conversation
Morriar
left a comment
Morriar
left a comment
There was a problem hiding this comment.
Nice find. But what was making the test pass sometimes and sometimes not
I think it has been consistently failing on Ruby 4, probably due to some recent Bundler changes. Not really sure, tbh. I was able to recreate on my local machine with Ruby 4.0.0 and Bundler 4.0.3, and was able to solve it this way. |
Apparently missing gem specs are only populated if the platform for the declared gem is one of the platforms Bundler is installing for. Since `:rbx` wasn't one of the added platforms, the gem was completely being ignored. However, we can't just add `:rbx` as a platform to the lockfile since (a) it is not a platform supported by RubyGems anymore, and (b) it isn't a platform that Sorbet has any support for. Of the platforms supported by RubyGems, the one that we can also resolve Sorbet against seems only to be the `:jruby` platform. So, adding the gem that we expect to be missing as a `:jruby` platform gem and then adding `:jruby` as a platform to the lockfile resurfaces the missing gem spec again.
paracycle
force-pushed
the
uk-fix-missing-specs-test
branch
from
182b76d to
17aa29a
Compare
I'm not sure, I see some status where Maybe it depends on the test order somehow? 🤔 |
|
Sorry, I misspoke. Somehow it was consistently failing on Ruby 4.0 and Rails current. Not sure what was different about Rails 8.0 that didn't make it fail. |
|
Actually, even that isn't true, I see all kinds of different ones failing. I was able to recreate it by running the test on its own on my branch, though, so that was lucky. |
3 participants
Apparently missing gem specs are only populated if the platform for the declared gem is one of the platforms Bundler is installing for. Since
:rbxwasn't one of the added platforms, the gem was completely being ignored.However, we can't just add
:rbxas a platform to the lockfile since (a) it is not a platform supported by RubyGems anymore, and (b) it isn't a platform that Sorbet has any support for.Of the platforms supported by RubyGems, the one that we can also resolve Sorbet against seems only to be the
:jrubyplatform. So, adding the gem that we expect to be missing as a:jrubyplatform gem and then adding:jrubyas a platform to the lockfile resurfaces the missing gem spec again.