Skip to content

Conversation

@rafaelfranca
Copy link
Member

This will allow us to have the same environment as the rest of the company.

This will allow us to have the same environment as the rest of the company.
@rafaelfranca rafaelfranca requested a review from a team as a code owner January 21, 2026 19:59
@Morriar Morriar added the chore label Jan 21, 2026
Comment on lines +10 to +11
- libyaml
- zlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these needed because ruby depends on them? If so, isn't that something that should be baked into the requirements of the ruby derivation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libyaml because of psych and zlib because of faraday-gzip that depends on the zlib gem. If those gems weren't being required in the Gemfile.lock those packages would not be needed, so no, I don't think it should be in the ruby derivation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But psych and zlib are both default gems, so they should be coming with a Ruby installation, and their dependencies should also be pulled in by default, no? (I am not sure if the zlib gem has a dependency on the zlib package, but psych should definitely be pulling libyaml in)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libyaml and zlib as just needed to build Ruby. After it is built you don't need it anymore. You only need again if you aren't using the Ruby default gems and is building it from source again, which is the case here, no? Now, why rubygems is building from source and not using the default gem I don't know. Maybe different versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't mean to hold up this PR for this, we can discuss async as well, but my understanding of the Nix store was that dependencies of things that you installed persisted in the store, so I was expecting at least libyaml to be present after installing ruby. But, maybe my assumptions are wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is what I thought. The derivation has it as build packages. After it is built it is gone https://github.com/bobvanderlinden/nixpkgs-ruby/blob/master/ruby/package-fn.nix#L76-L79.

Maybe we should add to our own ruby flake, but we don't have one right now, AFAIK

@rafaelfranca rafaelfranca disabled auto-merge January 21, 2026 20:25
@rafaelfranca rafaelfranca merged commit 16cec23 into main Jan 21, 2026
20 of 21 checks passed
@rafaelfranca rafaelfranca deleted the rmf-nix branch January 21, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants