Fix visible_if support for resource-based settings #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add visible_if support to article, blog, collection, collection_list, metaobject, metaobject_list, page, product, and product_list settings - Update schema definitions to include conditionalSetting reference - Remove resource-based settings from SETTINGS_TYPES_NOT_SUPPORTING_VISIBLE_IF test constant Fixes issue where CLI incorrectly rejected valid visible_if usage on resource-based settings
|
I have signed the CLA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The schema validation incorrectly flagged
visible_ifas not allowed on resource-based settings (article, blog, collection, collection_list, metaobject, metaobject_list, page, product, product_list), causing the CLI to show "Property visible_if is not allowed" errors. However, these settings actually do supportvisible_ifand function correctly when used in Shopify themes.This may have prevented developers from using this functionality where valid as working code was being flagged as invalid by the tooling.
Solution
Updated all resource-based settings to support
visible_ifby:conditionalSettingreference to their schema definitionsvisible_if: trueto their propertiesTesting
Verified that
visible_ifworks correctly on all resource-based settings in actual Shopify themes.