-
Notifications
You must be signed in to change notification settings - Fork 65
introduced snippet tag in ohm #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cc9fb5c to
ff32bd1
Compare
ff32bd1 to
782619c
Compare
charlespwd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 👌
782619c to
d2d4afb
Compare
aswamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments, but makes sense! Good stuff 👏
d2d4afb to
be6edd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, @shoplando! As soon as we fix that minor issue in the unit test, I believe we will be ready to merge 🚀 :)
…html syntax error theme check test to pass CI
Merge activity
|

What are you adding in this PR?
Solves issue #830
This PR adds support for the
snippetLiquid tag to the Liquid HTML parser. The implementation includes:snippettag to the grammar inliquid-html.ohmThe snippet tag allows for reusable content blocks similar to the
capturetag, with the syntax:{% snippet variable_name %} <content> {% endsnippet %}What's next? Any followup issues?
What did you learn?
Working with block-level Liquid tags requires updates across multiple layers of the parser, from grammar definition to AST transformation and formatting.
Before you deploy
changeset