Allow disabling theme docset augmentation for vanilla liquid LSP #1095
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavbls
changed the title
graygilmore
reviewed
Jan 5, 2026
| fetchMetafieldDefinitionsForURI: (uri: URI) => Promise<void>; | ||
|
|
||
| /** | ||
| * Controls augmentation of the provided ThemeDocset. |
Contributor
There was a problem hiding this comment.
Maybe we could be a little more specific here. Something like:
Suggested change
| * Controls augmentation of the provided ThemeDocset. | |
| * Controls whether Shopify-specific Liquid should be included |
And we could even rename the option to something like includeShopifyTags or something like that. @Shopify/developer-tools what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Right now, there is no way to disable the augmentation of the docset.
This PR adds the option to disable augmentation and remove completions that are not part of the Liquid language specification.
Adds optional
augmentDocset?: booleandependency (default true) so consumers can run a vanilla Liquid LSP without wrapping the docset inAugmentedThemeDocset.Before you deploy
changeset