Ignore Jujutsu VFS scheme to prevent fs.readDirectory errors #1097
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tien-ekn
force-pushed
the
fix/ignore-jj-vfs
branch
from
37610e9 to
e98487c
Compare
tien-ekn
force-pushed
the
fix/ignore-jj-vfs
branch
from
e98487c to
4fca8ef
Compare
graygilmore
approved these changes
Jan 8, 2026
Contributor
graygilmore
left a comment
graygilmore
left a comment
There was a problem hiding this comment.
Seems reasonable enough!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
While trying Jujutsu (jj) in VS Code, I noticed that opening a diff from the Source Control panel triggers an error notification about the unsupported
fs.readDirectorymethod.The extension already ignores VFS schemes used by Git. This PR extends the same logic to also ignore the Jujutsu VFS scheme, preventing the error from being triggered.
What's next? Any followup issues?
No follow-up planned.
For now, I’m currently using a local build of the Shopify extension to avoid this error notification issue. Hopefully this can be merged so I no longer need to do that 🙂.
Before you deploy
changeset