Skip to content

Conversation

@melissaluu
Copy link
Contributor

@melissaluu melissaluu commented Nov 18, 2024

Do Not Merge: Will need to rebase after #2379 ships so we can update this PR to include the GenericPicker being available in ActionExtensionsApi

Background

Related to https://github.com/Shopify/app-ui/issues/1756
Should ship after https://github.com/Shopify/web/pull/146520 and #2379
Follow up shopify-dev PR https://github.com/Shopify/shopify-dev/pull/50766

Add resourcePicker and genericPicker Api to Action Extension Api to support the new Resource Picker availability in action extensions.

Solution

Update the ActionExtensionApi interface to include the ResourcePickerApi and GenericPickerApi

NOTE: Will need to check on https://github.com/Shopify/shopify-dev/pull/49753 to see if there's verbage we'll need to update in https://github.com/Shopify/ui-extensions/blob/unstable/packages/ui-extensions/docs/surfaces/admin/staticPages/admin-extensions.doc.ts so it doesn't say blocks only.

🎩

Before:
image

After:
image

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@melissaluu melissaluu closed this Nov 18, 2024
@melissaluu melissaluu force-pushed the ml/action-extension-resource-picker-docs branch from b699449 to eb564c6 Compare November 18, 2024 22:57
@melissaluu melissaluu reopened this Nov 18, 2024
@melissaluu melissaluu force-pushed the ml/action-extension-resource-picker-docs branch from d21d11d to 062aa23 Compare November 28, 2024 20:57
@melissaluu melissaluu marked this pull request as ready for review November 28, 2024 21:14
@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@melissaluu melissaluu requested a review from a team November 28, 2024 22:07
Copy link
Contributor

@MitchLillie MitchLillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@billfienberg
Copy link
Contributor

🎩 Tophat

Before (main)

🙈 resourcePicker is absent.

image

After (ml/action-extension-resource-picker-docs)

👀 resourcePicker is present.

image
Screen.Recording.2024-12-06.at.14.18.21.mov

@melissaluu melissaluu force-pushed the ml/action-extension-resource-picker-docs branch from 062aa23 to b2d3ee7 Compare December 10, 2024 21:14
@melissaluu melissaluu merged commit 6de49d9 into unstable Dec 12, 2024
6 checks passed
kjbrum pushed a commit that referenced this pull request Dec 12, 2024
…cker-docs

[Admin Extension Docs] Add `resourcePicker` to Action Extension Api docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants