-
Notifications
You must be signed in to change notification settings - Fork 52
POS Image Sizing & Box Component #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
82994ef to
624918a
Compare
|
We detected some changes in |
js-goupil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid so far! I think we need to make sure we follow the UI API Design guide since this is a net new component. Let me know if you want to pair on this
packages/ui-extensions/src/surfaces/point-of-sale/render/components/Box/Box.ts
Outdated
Show resolved
Hide resolved
624918a to
d328765
Compare
js-goupil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If we find anything as we play with it write and examples we can fix it
packages/ui-extensions/src/surfaces/point-of-sale/render/components/Image/Image.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/render/components/Image/Image.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/render/components/shared/box.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/render/components/shared/box.ts
Show resolved
Hide resolved
0995a36 to
2212600
Compare
packages/ui-extensions/src/surfaces/point-of-sale/render/components/Image/Image.ts
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/render/components/shared/box.ts
Show resolved
Hide resolved
1f4055c to
650d286
Compare
fb5e6b1 to
54070e4
Compare
Background
https://github.com/Shopify/pos-next-react-native/issues/26551
Using the POS UI Extensions package, Images were unable to be resized. As a result, developers were experiencing challenges with displaying content using images such as QR codes. This PR aims to address these problems by exposing sizing options for image, as well as add a Box component, which will allow for images to be resized according to the dimensions of the box.
This is one of two PRs:
Solution
sizeandresizeModeprops for Image, following the provided standards from the POS Design System for Image.Block.Image.and.Box.Examples.mov
Box.Demo.Modal.mov
🎩
yalc-local-extensionsscript.Checklist