Skip to content

Conversation

@vctrchu
Copy link
Contributor

@vctrchu vctrchu commented Dec 12, 2024

Part of https://github.com/Shopify/pos-next-react-native/issues/47964

Background

Updates the addLineItem and addCustomSale interfaces to return UUID strings or undefined when promises complete.

@vctrchu vctrchu self-assigned this Dec 12, 2024
@vctrchu vctrchu changed the title Return the uuid for add line item actions Return UUIDs from addLineItem and addCustomSale Dec 12, 2024
@vctrchu
Copy link
Contributor Author

vctrchu commented Dec 12, 2024

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @vctrchu! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/data-extensions": "0.0.0-snapshot-20241212204821",
"@shopify/ui-extensions": "0.0.0-snapshot-20241212204821",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241212204821"

@vctrchu vctrchu changed the title Return UUIDs from addLineItem and addCustomSale Add bulkCartUpdate action and return UUIDs for add line items Dec 12, 2024
@vctrchu vctrchu changed the title Add bulkCartUpdate action and return UUIDs for add line items Return UUIDs from addLineItem and addCustomSale Dec 13, 2024
@vctrchu vctrchu marked this pull request as ready for review December 13, 2024 17:18
@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@vctrchu vctrchu force-pushed the vic/return-uuids-add-line-item branch from d2cbdd0 to c59e57c Compare December 16, 2024 19:31
@vctrchu vctrchu requested a review from NathanJolly December 16, 2024 20:11
Add to version docs

Remove undefined from type
@vctrchu vctrchu force-pushed the vic/return-uuids-add-line-item branch from c59e57c to 8732175 Compare December 16, 2024 20:42
@vctrchu vctrchu merged commit 9ce3684 into unstable Dec 16, 2024
6 checks passed
@vctrchu vctrchu deleted the vic/return-uuids-add-line-item branch December 16, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants