-
Notifications
You must be signed in to change notification settings - Fork 51
Added navigation to POS pages and canNavigate function to Navigation API #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
714448c
to
bad06fd
Compare
ee35d22
to
1195308
Compare
/snapit |
🫰✨ Thanks @thunderfern! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250808202129" |
1195308
to
d1c1fad
Compare
katriciab
approved these changes
Aug 11, 2025
.changeset/forty-files-relax.md
Outdated
'@shopify/ui-extensions': minor | ||
--- | ||
|
||
Updated the navigation function in Navigation API to allow for navigation to POS native pages and added a canNavigate function to allow partners to check if they can navigate to the specified pos page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Updated the navigation function in Navigation API to allow for navigation to POS native pages and added a canNavigate function to allow partners to check if they can navigate to the specified pos page | |
Updated the navigation function in Navigation API to allow for navigation to POS native screen and added a canNavigate function to allow partners to check if they can navigate to the specified POS native screen |
d1c1fad
to
d97deeb
Compare
NathanJolly
approved these changes
Aug 12, 2025
…o the Navigation API
d97deeb
to
7a98f44
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Resolves https://github.com/shop/issues-retail/issues/1810 and https://github.com/shop/issues-retail/issues/8397. This PR is made together with this PR.
Solution
We have decided to overload the
navigate
function with our newnavigate
function. This works with the implementation seen in thepos-next-react-native
repo in the PR linked above. (Two declarations but one implementation). We have also added acanNavigate
function to allow partners to check if the user has permissions to access the resource and adjust their flows accordingly.Note: Documentation and e2e tests will be updated in later PRs, referencing this issue and this issue.
🎩
Checklist