Skip to content

Conversation

@mcvinci
Copy link
Contributor

@mcvinci mcvinci commented Nov 14, 2025

This PR:

Tophatting

  1. In the ui-extensions repo, run yarn docs:point-of-sale 2025-01.
  2. In shopify-dev, run a server (dev server) and review the 2025-01 docs (descriptions for targets, APIs, and components) at https://shopify-dev.shop.dev/docs/api/pos-ui-extensions/2025-01

Known issues

  • Unable to create different descriptions on API and component index pages versus detailed API and component pages. For the time being, I've just added the long description that is intended for the details pages.
  • Some nested descriptions get duplicated, given the existing generated docs infrastructure. Hoping that we can resolve this as we continue the templated refs project work.

Focus for reviewers

I'm mainly looking for a gut-check on the following:

  • Do the descriptions convey the necessary context?
  • Are the descriptions positioned in the right place? (Typically, above interfaces and fields)
  • Are the changes scoped to descriptions only? Or have we accidentally updated / added types?

@mcvinci mcvinci added the #gsd:47443 Templated References https://vault.shopify.io/gsd/projects/47443 label Nov 14, 2025
@mcvinci mcvinci changed the base branch from 2025-10 to 2025-01 November 14, 2025 06:58
@mcvinci mcvinci marked this pull request as ready for review November 14, 2025 07:20
@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

linting

linting

linting

More description improvements

type errors

Remove event data files not needed in 2025-01 version and revert BaseInput/BaseIntent to original names

Remove new files that don't belong in 2025-01 version

More descriptions

Add descriptions to BaseInput and BaseIntent, fix TaxLine import error

FormattedTextField desc
@mcvinci mcvinci force-pushed the pos-ui-extensions-2025-01-api-prop-descriptions branch from 8ca06bf to 785c495 Compare November 14, 2025 07:23
@mcvinci mcvinci self-assigned this Nov 14, 2025
@mcvinci mcvinci changed the title [POS UI extensions]: Improved API, component, and prop descriptions for 2025-01 [POS UI extensions]: Improved target, API, and component descriptions for 2025-01 Nov 17, 2025
Copy link

@johndcollett johndcollett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structure looks good.

@mcvinci mcvinci merged commit c919cdf into 2025-01 Nov 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:47443 Templated References https://vault.shopify.io/gsd/projects/47443

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants