add tipAmount to BaseTransactionComplete type #3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadcromwell
requested review from
alexgraffeocohen,
antonino-u and
mauriciosierra
This comment has been minimized.
This comment has been minimized.
fatbattk
approved these changes
Nov 20, 2025
chadcromwell
added a commit
that referenced
this pull request
Nov 21, 2025
### Background Our compliance partners need tipAmount available in the data payload they receive for reporting. This PR updates the BaseTransactionComplete type to include tipAmount as optional. shop/issues-retail#20523 shop/issues-retail#20463 ### Solution Add tipAmount to BaseTransactionComplete type ### Checklist - [x] I have 🎩'd these changes - [ ] I have updated relevant documentation
chadcromwell
added a commit
that referenced
this pull request
Nov 21, 2025
### Background Our compliance partners need tipAmount available in the data payload they receive for reporting. This PR updates the BaseTransactionComplete type to include tipAmount as optional. shop/issues-retail#20523 shop/issues-retail#20463 ### Solution Add tipAmount to BaseTransactionComplete type ### Checklist - [x] I have 🎩'd these changes - [x] I have updated relevant documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Our compliance partners need tipAmount available in the data payload they receive for reporting. This PR updates the BaseTransactionComplete type to include tipAmount as optional.
https://github.com/shop/issues-retail/issues/20523
https://github.com/shop/issues-retail/issues/20463
Solution
Add tipAmount to BaseTransactionComplete type
Checklist