Skip to content

Conversation

@prakashraman
Copy link
Contributor

@prakashraman prakashraman commented Nov 28, 2025

Resolves https://github.com/shop/issues-retail/issues/18291

Background

Add a new example to the ChoiceList component documentation showing how to compose rich content within choices.

🎩

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Once deployed to production it should be available at https://shopify.dev/docs/api/pos-ui-extensions/latest/polaris-web-components/forms/choicelist

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prakashraman prakashraman marked this pull request as ready for review November 28, 2025 18:26
@prakashraman prakashraman changed the title add composed choice example to ChoiceList Add composed choice example to ChoiceList Nov 28, 2025
@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

Copy link
Contributor Author

Note: I don't, yet, know how to test these changes on staging.

@prakashraman prakashraman force-pushed the 11-28-add_composed_choice_example_to_choicelist branch from 88dc95d to 7d5f703 Compare November 28, 2025 18:28
Copy link
Contributor Author

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

I've chosen not to include a CHANGELOG.


{/* Mix of text and composed elements */}
<s-choice value="option3" disabled>
Option 3{' '}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note from Britta: Let's remove the {' '}

@prakashraman prakashraman force-pushed the 11-28-add_composed_choice_example_to_choicelist branch from 7d5f703 to 70f4570 Compare November 28, 2025 22:14
@BrittaEvansFenton
Copy link
Contributor

tophat looks great 👏🏻

Screenshot 2025-12-02 at 10 56 24 AM

Copy link
Contributor

@BrittaEvansFenton BrittaEvansFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@BrittaEvansFenton
Copy link
Contributor

let me know if you want to sync, I just found out there is another step. please make sure you link the update to Shopify.dev as well

Copy link
Contributor Author

Thanks for the walkthrough Britta.

I've tested it locally as well. Merging the PR now.

@prakashraman prakashraman merged commit c3fbcd6 into 2025-10 Dec 3, 2025
6 checks passed
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants