-
Notifications
You must be signed in to change notification settings - Fork 53
Add composed choice example to ChoiceList #3602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composed choice example to ChoiceList #3602
Conversation
|
We detected some changes in |
|
Note: I don't, yet, know how to test these changes on staging. |
88dc95d to
7d5f703
Compare
I've chosen not to include a CHANGELOG. |
|
|
||
| {/* Mix of text and composed elements */} | ||
| <s-choice value="option3" disabled> | ||
| Option 3{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note from Britta: Let's remove the {' '}
7d5f703 to
70f4570
Compare
BrittaEvansFenton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
|
let me know if you want to sync, I just found out there is another step. please make sure you link the update to Shopify.dev as well |
|
Thanks for the walkthrough Britta. I've tested it locally as well. Merging the PR now. |
|
Tophat link: https://pr-65602.shopify-dev.shopify.io/docs/api/pos-ui-extensions/latest/polaris-web-components/forms/choicelist (I've updated the PR description too) |


Resolves https://github.com/shop/issues-retail/issues/18291
Background
Add a new example to the ChoiceList component documentation showing how to compose rich content within choices.
🎩
Checklist