fix: Improve MySQL shutdown handling in vttestserver #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses cases where mysqld processes were not shutting down properly when vttestserver received SIGTERM signals, leading to orphaned processes and stale socket files. Key improvements: - Extended MySQL shutdown timeout from 60s to configurable 360s default - Added --mysql_shutdown_timeout CLI flag and MYSQL_SHUTDOWN_TIMEOUT env var - Implemented force shutdown with process cleanup (SIGTERM → SIGKILL) - Added automatic cleanup of stale socket and PID files - Enhanced error handling and logging for shutdown failures The timeout mismatch was the primary issue: vttest layer timed out at 60s while MySQL's shutdown timeout is 300s, causing premature cancellation. Changes: - go/vt/vttest/mysqlctl.go: Add TearDownWithTimeout() method - go/vt/vttest/local_cluster.go: Enhanced TearDown() with process cleanup - go/cmd/vttestserver/cli/main.go: Add --mysql_shutdown_timeout flag - docker/vttestserver/run.sh: Support MYSQL_SHUTDOWN_TIMEOUT env var - tools/debug_mysql_shutdown.sh: Debug script for troubleshooting - doc/MySQL_Shutdown_Fix.md: Comprehensive documentation Fixes prevent data corruption risks and container restart failures. Backward compatible with improved defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses cases where mysqld processes were not shutting down properly when vttestserver received SIGTERM signals, leading to orphaned processes and stale socket files.
Key improvements:
The timeout mismatch was the primary issue: vttest layer timed out at 60s while MySQL's shutdown timeout is 300s, causing premature cancellation.
Changes:
Fixes prevent data corruption risks and container restart failures. Backward compatible with improved defaults.
Related Issue(s)
Checklist
Deployment Notes