Conversation
gabypancu
approved these changes
Mar 25, 2026
Fixes phone validation for newly allocated number prefixes (e.g. Saudi Arabia 57x) that were incorrectly rejected by the older libphonenumber metadata. Also bumps mocha from 2.0.2 to 3.1.0 for compatibility with newer minitest versions in CI.
o-benz
force-pushed
the
obenz/bump-phonelib
branch
from
b89b5bf to
26798e9
Compare
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
PR 1/3 https://github.com/shop/issues-checkout/issues/11254.
What approach did you choose and why?
Fixes phone validation for newly allocated number prefixes (e.g. Saudi Arabia 57x) that were incorrectly rejected by the older libphonenumber metadata.
Testing
All 6 tests, 640 assertions pass cleanly,no failures, no errors. The phonelib bump from 0.8.7 to 0.10.17 doesn't break any existing phone tests, so no test changes are needed on PR 1.
Checklist