Skip to content

output stderr when running ssh commands #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frikky merged 4 commits into from
Jun 15, 2025
Merged

output stderr when running ssh commands #406

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c587971
output stderr when running ssh commands
yashsinghcodes Apr 22, 2025
3f2bd41
provide stderr for ssh commands
yashsinghcodes May 5, 2025
de2914e
fixed grammar
yashsinghcodes May 5, 2025
efafb3f
added try-catch in output and error_log
yashsinghcodes Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions shuffle-tools/1.2.0/src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2633,14 +2633,10 @@ def run_ssh_command(self, host, port, user_name, private_key_file_id, password,
try:
stdin, stdout, stderr = ssh_client.exec_command(str(command))

stderr_ouput = stderr.read().decode(errors='ignore')

if stderr_ouput:
return {"success": "true", "message": stderr_ouput}
except Exception as e:
return {"success":"false","message":str(e)}

return {"success":"true","output": stdout.read().decode(errors='ignore')}
return {"success":"true","output": stdout.read().decode(errors='ignore'), "error_log": stderr.read().decode(errors='ignore')}
Copy link
Member

@frikky frikky May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't stderr.read() and stdout.read() be try-caught? Those can easily crash. The decode as well.


def cleanup_ioc_data(self, input_data):
# Remove unecessary parts like { and }, quotes etc
Expand Down
Loading