Update docs for delete suborg api #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frikky
reviewed
Jun 23, 2025
docs/API.md
Outdated
|
|
||
| ```bash | ||
| curl -XDELETE https://shuffler.io/api/v1/orgs/{org_id} -H "Authorization: Bearer APIKEY" | ||
| curl -XDELETE https://shuffler.io/api/v1/orgs/{parent_org_id} -H "Authorization: Bearer APIKEY" |
Member
There was a problem hiding this comment.
Wait, this is scary af. Why don't we just send the delete request directly to the suborg ID?
How didn't I catch this lol
Contributor
Author
There was a problem hiding this comment.
Because we need to verify whether user who is sending request for suborg deletion is admin in parent org or not.
But we do have check for whether org which is being deleted is suborg or not.
Contributor
Author
There was a problem hiding this comment.
@frikky, I have changed the docs. Now Only with suborg id user can delete that suborg
frikky
reviewed
Jun 23, 2025
Member
frikky
left a comment
frikky
left a comment
There was a problem hiding this comment.
We need to revert this change. Sending delete requests to your parent ID is not at all an option
Member
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.