Skip to content

added constraints for infinite for loop #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashsinghcodes merged 2 commits into from
Jan 30, 2025
Merged

added constraints for infinite for loop #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2faf9a0
added constraints for infinite for loop
yashsinghcodes Jan 30, 2025
8c29702
count only when error occurs for GetAllWorkflowExecutionsV2 function
yashsinghcodes Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions db-connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6254,12 +6254,22 @@ func GetPrioritizedApps(ctx context.Context, user User) ([]WorkflowApp, error) {
if user.ActiveOrg.Id != "" {
query := datastore.NewQuery(nameKey).Filter("reference_org =", user.ActiveOrg.Id).Limit(queryLimit)
//log.Printf("[INFO] Before ref org search. Org: %s\n\n", user.ActiveOrg.Id)
maxAmount := 100
cnt := 0
for {
it := project.Dbclient.Run(ctx, query)
if cnt > maxAmount {
log.Printf("[ERROR] Maximum try excided for workflowapp (1)")
}

for {
innerApp := WorkflowApp{}
_, err := it.Next(&innerApp)
cnt += 1
if cnt > maxAmount {
log.Printf("[ERROR] Maximum try excided for workfloapp (2)")
}

if err != nil {
if strings.Contains(fmt.Sprintf("%s", err), "cannot load field") {
//log.Printf("[ERROR] Error in reference_org app load of %s (%s): %s.", innerApp.Name, innerApp.ID, err)
Expand Down Expand Up @@ -11045,16 +11055,28 @@ func GetAllWorkflowExecutionsV2(ctx context.Context, workflowId string, amount i
// Create a timeout to prevent the query from taking more than 5 seconds total

cursorStr := ""
maxAmount := 100
cnt := 0
for {
it := project.Dbclient.Run(ctx, query)
if cnt > maxAmount {
log.Printf("[ERROR] Error getting workflow execution (4): reached maximum retries")
break
}

breakOuter := false
for {
innerWorkflow := WorkflowExecution{}
_, err := it.Next(&innerWorkflow)
if cnt > maxAmount {
log.Printf("[ERROR] Error getting workflow execution (3): reached maximum retries")
break
}

if err != nil {
if strings.Contains(err.Error(), "context deadline exceeded") {
log.Printf("[WARNING] Error getting workflow executions (1): %s", err)
cnt += 1
breakOuter = true
} else {
if strings.Contains(err.Error(), `cannot load field`) {
Expand Down
Loading