Skip to content

check baseExecution before validating worker request #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frikky merged 1 commit into from
Dec 17, 2025
Merged

check baseExecution before validating worker request #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22086,6 +22086,11 @@ func ValidateNewWorkerExecution(ctx context.Context, body []byte, shouldReset bo
return errors.New(fmt.Sprintf("Bad length of trigger: %d (probably normal app)", len(execution.Workflow.Triggers)))
}

if baseExecution.Status == "FINISHED" || baseExecution.Status == "ABORTED" || baseExecution.Status == "FAILURE" {
log.Printf("[INFO][%s] Execution is already finished, not overriding", execution.ExecutionId)
return errors.New("Execution is already finished, not overriding")
}

if len(baseExecution.Results) > len(execution.Results) {
if shouldReset == true {
// Letting it pass and override. This is to ensure worker can override
Expand Down
Loading