Skip to content

Support for missing works_max#33

Open
osy wants to merge 2 commits intoShugabuga:masterfrom
osy:no-max-supported
Open

Support for missing works_max#33
osy wants to merge 2 commits intoShugabuga:masterfrom
osy:no-max-supported

Conversation

@osy
Copy link

@osy osy commented Dec 26, 2020

Allow a package to not have to specify the max compatible version.

Copy link
Owner

@Shugabuga Shugabuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to review this PR. Just curious on why you did a few things:

  1. Why did you remove the text "iOS" from the web template?
  2. In DebianPackager.py, why did omit compatible_max if a user wants to provide their own tags?

@osy
Copy link
Author

osy commented Jan 28, 2021

  1. Because tweak_compatibility already has the word “iOS” so the web template shows up as “iOS iOS 11”
  2. Because in my use case I had a compatible_min but no compatible_max and it threw an error. I changed it to make compatible_max optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants