fix(libs): estimated block height uses dynamic genesis - #1301
Merged
alexfreska merged 1 commit intoDec 24, 2025
Conversation
🦋 Changeset detectedLatest commit: 9e8a104 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexfreska
commented
Sep 3, 2025
alexfreska
requested review from
n8mgr and
telestrial
and removed request for
Copilot
September 3, 2025 13:15
alexfreska
force-pushed
the
fix_libs_estimated_block_height_uses_dynamic_genesis
branch
from
September 3, 2025 13:15
7bbbd72 to
8bda935
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the estimated block height calculation to use a dynamic genesis timestamp instead of hardcoded network-specific values. The change consolidates multiple network-specific block height functions into a single dynamic function that accepts a genesis timestamp parameter.
- Replaces hardcoded mainnet and testnet genesis timestamps with dynamic genesis timestamp parameter
- Consolidates
getMainnetBlockHeightandgetTestnetZenBlockHeightfunctions intogetBlockHeightFromGenesis - Updates all consumers to use the new dynamic function with
hardforkOak.genesisTimestamp
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/units/src/blockHeight.ts | Replaces network-specific functions with single dynamic function accepting genesis timestamp |
| libs/walletd-react/src/api.ts | Updates to use new dynamic block height function with network genesis timestamp |
| libs/renterd-react/src/bus.ts | Updates to use new dynamic block height function with state genesis timestamp |
| libs/hostd-react/src/api.ts | Updates to use new dynamic block height function with state genesis timestamp |
| .changeset/cute-badgers-fly.md | Documents the breaking change for affected packages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexfreska
force-pushed
the
fix_libs_estimated_block_height_uses_dynamic_genesis
branch
from
September 3, 2025 15:09
8bda935 to
5bab94b
Compare
alexfreska
commented
Sep 3, 2025
alexfreska
force-pushed
the
fix_libs_estimated_block_height_uses_dynamic_genesis
branch
from
September 3, 2025 15:12
5bab94b to
094dc83
Compare
alexfreska
marked this pull request as draft
September 22, 2025 13:35
Member
Author
|
@n8mgr @ChrisSchinnerl not incredibly high priority but bumping this PR. Its blocked because there is no API that provides access to |
Member
|
@alexfreska it looks like |
alexfreska
force-pushed
the
fix_libs_estimated_block_height_uses_dynamic_genesis
branch
from
December 22, 2025 16:34
094dc83 to
e00bf4a
Compare
alexfreska
changed the base branch from
graphite-base/1301
to
feat_indexd_add_consensus_apis
December 22, 2025 16:34
This was referenced Dec 22, 2025
alexfreska
marked this pull request as ready for review
December 22, 2025 16:35
telestrial
approved these changes
Dec 22, 2025
Member
Author
Merge activity
|
alexfreska
changed the base branch from
feat_indexd_add_consensus_apis
to
graphite-base/1301
December 24, 2025 00:34
alexfreska
force-pushed
the
fix_libs_estimated_block_height_uses_dynamic_genesis
branch
from
December 24, 2025 00:35
e00bf4a to
9e8a104
Compare
alexfreska
deleted the
fix_libs_estimated_block_height_uses_dynamic_genesis
branch
December 24, 2025 00:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
walletd --network=anagamishows a wrong target height in the UI walletd#238