Skip to content

refactor(indexd): remove service account columns from accounts UI#1462

Merged
telestrial merged 1 commit intomainfrom
03-16-refactor_indexd_remove_service_account_columns_from_accounts_ui
Mar 16, 2026
Merged

refactor(indexd): remove service account columns from accounts UI#1462
telestrial merged 1 commit intomainfrom
03-16-refactor_indexd_remove_service_account_columns_from_accounts_ui

Conversation

@telestrial
Copy link
Copy Markdown
Contributor

@telestrial telestrial commented Mar 16, 2026

Removes serviceAccount, as SiaFoundation/indexd#794 suggests. Adding @ChrisSchinnerl to make sure I'm interpreting this correctly. This removes serviceAccount completely on our end.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 16, 2026

🦋 Changeset detected

Latest commit: d5a14d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siafoundation/indexd-types Minor
indexd Minor
@siafoundation/indexd-js Patch
@siafoundation/indexd-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
indexd Ready Ready Preview, Comment Mar 16, 2026 2:27pm
4 Skipped Deployments
Project Deployment Actions Updated (UTC)
explorer Ignored Ignored Preview Mar 16, 2026 2:27pm
explorer-zen Ignored Ignored Preview Mar 16, 2026 2:27pm
hostd Ignored Ignored Preview Mar 16, 2026 2:27pm
renterd Ignored Ignored Preview Mar 16, 2026 2:27pm

Request Review

@github-project-automation github-project-automation bot moved this to In Progress in Sia Mar 16, 2026
Copy link
Copy Markdown
Contributor Author

telestrial commented Mar 16, 2026

@telestrial telestrial marked this pull request as ready for review March 16, 2026 14:27
Copilot AI review requested due to automatic review settings March 16, 2026 14:27
@claude
Copy link
Copy Markdown

claude bot commented Mar 16, 2026

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the serviceAccount field from the indexd admin account typings and strips the corresponding “Service account” UI surfaces from the accounts table and side panel, aligning the UI/types with the API change described in indexd issue #794.

Changes:

  • Removed serviceAccount from Account / account UI data types and the account transform mapping.
  • Removed the “Service account” column and side-panel info row from the indexd Accounts UI.
  • Removed the serviceaccount query param from the admin accounts route params and added a changeset documenting the change.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/indexd-types/src/admin/types.ts Drops serviceAccount from the exported Account type.
libs/indexd-types/src/admin/index.ts Removes serviceaccount from AdminAccountsParams.
apps/indexd/components/Data/Accounts/types.ts Removes serviceAccount from the UI-facing AccountData type.
apps/indexd/components/Data/Accounts/transform.ts Stops mapping serviceAccount into UI data.
apps/indexd/components/Data/Accounts/accountsColumns.tsx Removes the “Service account” column from the accounts table.
apps/indexd/components/Data/Accounts/SidePanelAccount.tsx Removes the “Service account” row from the account side panel.
.changeset/shaky-poets-wear.md Records a minor bump for @siafoundation/indexd-types and indexd.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Copy Markdown
Contributor Author

telestrial commented Mar 16, 2026

Merge activity

  • Mar 16, 7:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 16, 7:52 PM UTC: @telestrial merged this pull request with Graphite.

@telestrial telestrial merged commit 76ee23f into main Mar 16, 2026
59 checks passed
@telestrial telestrial deleted the 03-16-refactor_indexd_remove_service_account_columns_from_accounts_ui branch March 16, 2026 19:52
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants