refactor(indexd): remove service account columns from accounts UI#1462
Conversation
🦋 Changeset detectedLatest commit: d5a14d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Claude Code ReviewThis repository is configured for manual code reviews. Comment |
There was a problem hiding this comment.
Pull request overview
Removes the serviceAccount field from the indexd admin account typings and strips the corresponding “Service account” UI surfaces from the accounts table and side panel, aligning the UI/types with the API change described in indexd issue #794.
Changes:
- Removed
serviceAccountfromAccount/ account UI data types and the account transform mapping. - Removed the “Service account” column and side-panel info row from the indexd Accounts UI.
- Removed the
serviceaccountquery param from the admin accounts route params and added a changeset documenting the change.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/indexd-types/src/admin/types.ts | Drops serviceAccount from the exported Account type. |
| libs/indexd-types/src/admin/index.ts | Removes serviceaccount from AdminAccountsParams. |
| apps/indexd/components/Data/Accounts/types.ts | Removes serviceAccount from the UI-facing AccountData type. |
| apps/indexd/components/Data/Accounts/transform.ts | Stops mapping serviceAccount into UI data. |
| apps/indexd/components/Data/Accounts/accountsColumns.tsx | Removes the “Service account” column from the accounts table. |
| apps/indexd/components/Data/Accounts/SidePanelAccount.tsx | Removes the “Service account” row from the account side panel. |
| .changeset/shaky-poets-wear.md | Records a minor bump for @siafoundation/indexd-types and indexd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Merge activity
|

Removes
serviceAccount, as SiaFoundation/indexd#794 suggests. Adding @ChrisSchinnerl to make sure I'm interpreting this correctly. This removes serviceAccount completely on our end.