feat: Add code and formatting guidelines #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SternXD
requested review from
JoeMatt,
Spidy123222,
lonkelle and
nythepegasus
as code owners
polymo1
reviewed
Sep 18, 2025
Member
polymo1
left a comment
polymo1
left a comment
There was a problem hiding this comment.
Before merging, I wish to view the compiled docusaurus result. I will report back when I have done so.
polymo1
requested changes
Sep 18, 2025
Member
polymo1
left a comment
polymo1
left a comment
There was a problem hiding this comment.
These are what I immediately see.
Otherwise, looking good from the docs end!
Member
Author
|
cc: @nythepegasus |
CelloSerenity
approved these changes
Sep 18, 2025
Member
|
anyone else? |
polymo1
approved these changes
Sep 18, 2025
neoarz
approved these changes
Sep 18, 2025
Member
|
Four approvals, probably fine to merge. |
Spidy123222
approved these changes
Sep 19, 2025
Member
Spidy123222
left a comment
Spidy123222
left a comment
There was a problem hiding this comment.
This looks good. I did wonder on how strong some of it is on requiring Xcode and Mac's. There's been advances in programs to make iOS apps on non Mac and not Xcode like crosscode and xtools. But things can be changed to adapt to upcoming programs if needed.
Member
Author
|
5 approvals seems like enough lol we'll just fix it if there's issues going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SideStore documentation to add code/formatting guidelines
Key Changes
Why?
These changes help new and existing contributors understand our expectations, improve code quality, and keep the project
not a shit show.