Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
genieutils already depends on
<filesystem>so we don't lose anything by doing the same.Includes a bunch of fixes to path conversion, where we were implicitly converting paths to strings, which is not portable, and I don't know why C++ even has that feature because it is a bad one.
The cmake changes here might also accidentally "fix" the miniz linking issues @twestura was running into—proper fix is in sandsmark/genieutils#9 but now we're compiling genieutils and WK into the same static library and WK also includes the miniz code, so it all ends up linking fine (at least on CI).