Implement a script to import dataset information from the game files#179
Merged
happyleavesaoc merged 3 commits intoSiegeEngineers:masterfrom Jan 31, 2026
Merged
Implement a script to import dataset information from the game files#179happyleavesaoc merged 3 commits intoSiegeEngineers:masterfrom
happyleavesaoc merged 3 commits intoSiegeEngineers:masterfrom
Conversation
| "838": "Siege Elephant", | ||
| "840": "Elite Ghulam", | ||
| "843": "Elite Shrivamsha Rider", | ||
| "843": "E. Shrivamsha Rider", |
Contributor
Author
There was a problem hiding this comment.
Yes, this is the description that is used in the Tech Tree, which is where I gather all the techs names. I agree the explicit version is better, and we can manually revert to that, but the script will always pick the translations as they are in the game
Contributor
There was a problem hiding this comment.
Maybe we can just apply a rule, something like:
if name.startswith("E. "):
name = "Elite" + name[2:]
There are already other rules in the script, so there's precedent I suppose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a script that will read the data from the game files and update the 100.json dataset file with that data. This should help reduce the cases where technologies and maps are missing in this library in comparison to what is found in the game.
The dataset was also updated with the output of the script.