Skip to content

adding can update alerts subject info#2708

Open
revmag wants to merge 2 commits intomainfrom
alerts-subject-update
Open

adding can update alerts subject info#2708
revmag wants to merge 2 commits intomainfrom
alerts-subject-update

Conversation

@revmag
Copy link
Collaborator

@revmag revmag commented Feb 12, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
signoz-web Ready Ready Preview, Comment Feb 12, 2026 10:47am

Request Review

@revmag revmag enabled auto-merge (squash) February 12, 2026 10:22
@claude
Copy link
Contributor

claude bot commented Feb 12, 2026

Claude finished @revmag's task in 1m 16s —— View job


Review Complete ✓

Tasks

  • Read CONTRIBUTING.md for review guidelines
  • Review changed file and diff
  • Check technical accuracy
  • Verify formatting and links
  • Provide review feedback

Documentation Review

This PR adds a new FAQ entry explaining how to edit alert subjects in SigNoz. The content is helpful, but there are a few issues that need to be addressed:

Issues Found

High Priority:

  1. Missing required frontmatter (data/docs/alerts-management/troubleshooting/faqs.mdx:6) - The description and doc_type fields are missing from the frontmatter metadata. These are required per CONTRIBUTING.md guidelines.

Medium Priority:
2. Internal link format (data/docs/alerts-management/troubleshooting/faqs.mdx:9) - Internal links should use absolute URLs with https://signoz.io prefix instead of site-relative paths.

  1. External reference relevance (data/docs/alerts-management/troubleshooting/faqs.mdx:20) - The Prometheus Alertmanager link points to a low-level template reference that may not be directly helpful for SigNoz users. Consider linking to SigNoz-specific docs or more practical examples instead.

What Works Well

  • Clear step-by-step instructions for editing alert subjects
  • Good use of the Admonition component to highlight limitations
  • Updated date field correctly
  • Content is concise and actionable

Recommendation

Please address the inline comments, particularly adding the missing frontmatter fields. Once these are resolved, the PR will be ready to merge.


Updated the FAQs with a new description and corrected a link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant