test: JSON QB Integration tests Suite#10085
Draft
piyushsingariya wants to merge 80 commits intomainfrom
Draft
Conversation
piyushsingariya
requested review from
srikanthccv and
vikrantgupta25
as code owners
piyushsingariya
requested review from
therealpandey and
tushar-signoz
and removed request for
srikanthccv,
therealpandey and
vikrantgupta25
piyushsingariya
added
safe-to-integrate
vikrantgupta25
requested changes
Feb 24, 2026
| from fixtures.logs import Logs | ||
|
|
||
|
|
||
| def _assert_ok(response: requests.Response) -> None: |
Member
There was a problem hiding this comment.
Suggested change
| def _assert_ok(response: requests.Response) -> None: | |
| def _assert_ok(response: requests.Response) -> None |
you don't need these small helper functions :/
| ) | ||
|
|
||
|
|
||
| def _build_query_payload( |
Member
There was a problem hiding this comment.
all of these should be in querier fixture please. we already have a makeQueryRequest there. Update where required.
piyushsingariya
added
safe-to-integrate
piyushsingariya
added
safe-to-integrate
piyushsingariya
added
safe-to-integrate
piyushsingariya
added
safe-to-integrate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📄 Summary
This change brings in NEW JSON QB tests suite
Issues closed by this PR
Closes SigNoz/engineering-pod#3474
✅ Change Type
Select all that apply