fix: add border color for table header in light mode#10521
Open
Yuki9814 wants to merge 1708 commits intoSigNoz:developfrom
Open
fix: add border color for table header in light mode#10521Yuki9814 wants to merge 1708 commits intoSigNoz:developfrom
Yuki9814 wants to merge 1708 commits intoSigNoz:developfrom
Conversation
This pull request improves the handling of field key resolution in query building. The main focus is to make the field key matching logic in the VisitKey function more robust, especially when dealing with context and data type prefixes.
…#9986) This pull request introduces significant improvements to the handling and normalization of telemetry field keys, adds comprehensive tests for these changes, and refactors JSON unmarshaling for query builder types to ensure consistent normalization and error handling
* chore: updated eslint base config with comments * chore: add eslint rules for no-else-return and curly * chore: add eslint rules for no-console * chore: add eslint rules for no-unused-vars * chore: fix more cases
…10082) * feat: create common run query btn * feat: update run query in explorer * feat: comment * feat: fix styles * feat: fix styles * feat: update style * feat: update btn in alerts * feat: added test cases * feat: replace run query btn * feat: bg change run query
* chore(env): add docs base url for staging and production * chore(env): add docs base url for staging and production * chore(env): add docs base url for staging and production
* feat(authz): initial commit for migrating rbac to openfga * feat(authz): make the role updates idempotant * feat(authz): split role module into role and grant * feat(authz): some naming changes * feat(authz): integrate the grant module * feat(authz): add support for migrating existing user role * feat(authz): add support for migrating existing user role * feat(authz): figure out the * selector * feat(authz): merge main * feat(authz): merge main * feat(authz): address couple of todos * feat(authz): address couple of todos * feat(authz): fix tests and revert public dashboard change * feat(authz): fix tests and revert public dashboard change * feat(authz): add open api spec * feat(authz): add open api spec * feat(authz): add api key changes and missing migration * feat(authz): split role into getter and setter * feat(authz): add integration tests for authz register * feat(authz): add more tests for user invite and delete * feat(authz): update user tests * feat(authz): rename grant to granter * feat(authz): address review comments * feat(authz): address review comments * feat(authz): address review comments * feat(authz): add the migration for existing roles * feat(authz): go mod tidy * feat(authz): fix integration tests * feat(authz): handle community changes * feat(authz): handle community changes * feat(authz): role selectors for open claims * feat(authz): role selectors for open claims * feat(authz): prevent duplicate entries for changelog * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration * feat(authz): scafolding for rbac migration
* feat: handle custom time ranges in timezones correctly * fix: improve timezone UI * fix: prettier issues * fix: show time in user selected timezone, overflow issue (SigNoz#10096) * fix: show time in user selected timezone, overflow issue, metadata loading * fix: add gap to popover row * fix: use inline conditional render for startTimeMs * fix: remove unused variable in CustomTimePicker * fix: remove unused variable in CustomTimePicker, TraceMetadata * fix: update timezone mock in SpanHoverCard test case
This pull request introduces a new utility file, `collision.go`, to the `querybuilder` package, which provides robust logic for handling duplicate and ambiguous field keys in query builder queries. The new functions ensure that queries are more resilient to naming collisions and ambiguities, especially when dealing with JSON and promoted fields. Additionally, several test cases have been updated to reflect improved handling and warning messages for ambiguous keys.
Co-authored-by: primus-bot[bot] <171087277+primus-bot[bot]@users.noreply.github.com>
Co-authored-by: primus-bot[bot] <171087277+primus-bot[bot]@users.noreply.github.com>
* fix: sidebar enhancement * fix: new source btn changes * fix: shortcut order changes * fix: changes in more section collapse behaviour * fix: sidebar shortcut changes, consistency, cleanup in collapse mode * fix: sidebar pin, tooltip and other changes * feat: updated alignment issues * fix: sidenav enhancement - fixes * fix: code fix * fix: sidenav enhancement * feat: addressed comments and feedback * feat: fix default shortcut empty issue * feat: code clean and improvements * feat: refactor and cleanup * feat: refactor and addressed comment * feat: removed isscrolled
…tions header (SigNoz#10123) - Removed search functionality from integrations - Added "View 150+ Data Sources" button that navigates to GET_STARTED_WITH_CLOUD route - Updated subtitle text to reflect curated integrations - Removed RequestIntegrationBtn from the page
This pull request introduces several improvements and bug fixes in the telemetry logs and traces statement builders, metadata key filtering, and integration tests. The most significant changes ensure that required fields are always present in queries, deprecated fields are handled correctly, and test coverage is expanded to handle edge cases such as corrupt data. Additionally, some code cleanup and formatting improvements are made.
Co-authored-by: primus-bot[bot] <171087277+primus-bot[bot]@users.noreply.github.com>
This reverts commit c0e2dad.
Co-authored-by: primus-bot[bot] <171087277+primus-bot[bot]@users.noreply.github.com> Co-authored-by: Pandey <vibhupandey28@gmail.com>
* fix: set appropriate datasource in grp by * feat: test cases added * feat: fix styles * feat: update test
* feat: has JSON QB * fix: tests expected queries and values * fix: ignored .vscode in gitignore * fix: tests GroupBy * revert: gitignore change * fix: build json plans in metadata * fix: empty filteredArrays condition * fix: tests * fix: tests * fix: json qb test fix * fix: review based on tushar * fix: changes based on review from Srikanth * fix: remove unnecessary bool checking * fix: removed comment * chore: var renamed * fix: merge conflict * test: fix * fix: tests * fix: go test flakiness --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
* chore: fixture for notification channel * chore: return notification channel info in Create notification channel API * fix: change scope of create channel fixture to function level * chore: added debug message on assertion failure * refactor: improve error handling in webhook notification channel deletion * chore: ran py linter and fmt * fix: silenced pylint on too broad exception * feat: add alerts to integration CI workflow * chore: removed clean from notification channel creation fixture + changes fixture scope of get_token * chore: reverted fixture scopes to function * fix: breaking alert test due to alert manager not registered for newly created org * chore: formatted and fix lint --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
* chore: updated eslint base config with comments * chore: add eslint rules for no-else-return and curly * chore: use isNumber from lodash-es * chore: add eslint rules for no-console * chore: update eslint overrides * chore: sort all files * chore: fix tests
… options (SigNoz#10150) * feat: show multiple labels with differing tags and types in filter options * feat: test fix
* chore: made baseconfigbuilder generic to be used across different charts * chore: updated baseconfigbuilder test * chore: updated timezone types * chore: fixed tsc + test * chore: fixed tsc + test * chore: fixed tsc + test * chore: updated config builder types * chore: updated comment
…oz#10480) * fix(frontend): dynamic vars load with empty textbox variables
…es (SigNoz#10110) * feat: merge conflicts * feat: testcases updated * feat: checkbox jitter updated * feat: css updated * feat: pr comments signal source * feat: relatedValues and all values together with unchecked filter handling * feat: unchecked show more and tooltip for adaptive * feat: test case * feat: testcase * fix: testcase
…gNoz#10432) * feat: redesign the custom domain and moved it to general settings * feat: cleanup and refactor * feat: updated and added test cases * feat: updated home page data source info section * feat: cleanup and refactor * feat: comment addressed * feat: comment addressed * feat: scss refactoring with semantic tokens * feat: update icons to use from signozhq * feat: added test config in jest and refactored code --------- Co-authored-by: Vikrant Gupta <vikrant@signoz.io>
* feat: added roles crud and details page * feat: added details page content * feat: added empty state in members tab * feat: added permission detail side panel * feat: made managed roles read only * feat: added authzresources call in the app context * feat: refactored files, made constants and utils * feat: updated test mocks and util * feat: added redirect to details page upon creation and other refactoring * feat: used enum and refactoring * feat: removed sidepanel toggle and changed the buildpayload logic * feat: moved authz resource to roles page from app context * feat: semantic token usage * feat: cleanup, comment address and refactor * feat: cleanup, comment address and refactor * feat: temporarily hide the crud and role details page * feat: added test cases for the role details flow and utilities * feat: added test config in jest and refactored code * feat: changed the page availability condition based on the tenant license type * feat: resolved merge conflict changes in settings util
Co-authored-by: primus-bot[bot] <171087277+primus-bot[bot]@users.noreply.github.com>
* fix: exclude internal attributes from promQL results * fix: __name__ can stay
… applied on popover close (SigNoz#10484) * fix: enhance input handling to prevent popover closure on input click * fix: handling of input changes in CustomTimePicker to ensure value is applied on popover close * chore: add test cases
…arts (SigNoz#10459) * chore: made baseconfigbuilder generic to be used across different charts * chore: updated baseconfigbuilder test * chore: updated timezone types * chore: fixed tsc + test * chore: fixed tsc + test * chore: fixed tsc + test * feat: added the base changes for pinnedtooltip element * chore: fix tsc + test * chore: fixed tooltipplugin test * chore: restructured the code * chore: restrucuted tooltip schema and resolved pr comments * chore: fixed cursor comments * chore: fixed cursor comments * chore: fixed cursor comments
…0504) * fix: added fix for tooltip not rendering in fullscreen mode * chore: added test for tooltip parent behaviour
…lds/valu…" (SigNoz#10508) This reverts commit 9a046ab.
Co-authored-by: primus-bot[bot] <171087277+primus-bot[bot]@users.noreply.github.com>
* feat: revamped the settings nav and setting dropdown * feat: settings nav categorisation * feat: added test cases * feat: refactored code * feat: updated test case * feat: added keyboard shortcuts back into the settings nav at the bottom section
* chore: enchance clickhouse log_comment * chore: enrich all clickhouse queries * fix: remove is_meatadata * fix: use the new func * fix: use semconv keys * fix: add more details * fix: minor changes * fix: address comments * fix: address cursor comments * fix: minor changes * fix: addressed comments * fix: address comments and move to module functions where possible --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
…0510) * chore(frontend): separate out columnWidths from ResizeTable * chore: fix tests
Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com>
- Added staticcheck for static analysis - Added godot for checking Go doc comments end with period
- Added cursor: pointer on hover for table rows in External APIs page - This improves UX by indicating rows are clickable
- Added border-bottom: 1px solid var(--bg-vanilla-300) to match other borders in light mode - This fixes issue SigNoz#9402 where border color didn't match in External APIs light mode
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 3. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
Yuki9814 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add proper border color to table header in External APIs page for light mode.
Issue
Issue #9402 - External APIs (light mode) -> border color doesn't match the other borders
Changes
border-bottom: 1px solid var(--bg-vanilla-300)to table headers in light mode