chore: separate dashboard slider from dashboard provider + refactor#10572
Open
AshwinBhatkal wants to merge 2 commits intomainfrom
Open
chore: separate dashboard slider from dashboard provider + refactor#10572AshwinBhatkal wants to merge 2 commits intomainfrom
AshwinBhatkal wants to merge 2 commits intomainfrom
Conversation
AshwinBhatkal
commented
Mar 12, 2026
AshwinBhatkal
commented
Mar 12, 2026
| @@ -0,0 +1,97 @@ | |||
| import { memo } from 'react'; | |||
Contributor
Author
There was a problem hiding this comment.
existing component
- Renamed
- memoized
- removal of useDashboard hook
- unification of queryParams
AshwinBhatkal
commented
Mar 12, 2026
| }, | ||
| }; | ||
|
|
||
| export const PANEL_TYPES_INITIAL_QUERY: Record<PANEL_TYPES, Query> = { |
Contributor
Author
There was a problem hiding this comment.
has been moved from the constants file with a change in line 573
AshwinBhatkal
commented
Mar 12, 2026
| @@ -1,5 +1,6 @@ | |||
| // ** Helpers | |||
Contributor
Author
There was a problem hiding this comment.
copied over from constants file except for 1 change
AshwinBhatkal
force-pushed
the
chore/issue-4053-remove-dashboard-slider-dashboard-provider
branch
from
db19e8f to
dd15db9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
Screenshots / Screen Recordings
Screen.Recording.2026-03-12.at.7.20.18.PM.mov
Screen.Recording.2026-03-12.at.7.22.46.PM.mov
Issues closed by this PR
Closes https://github.com/SigNoz/engineering-pod/issues/4053
Part of https://github.com/SigNoz/engineering-pod/issues/3953