Choose to overwrite maps & possible settings in new Settings.cfg#23
Open
seanth wants to merge 6 commits intoSigma88:masterfrom
Open
Choose to overwrite maps & possible settings in new Settings.cfg#23seanth wants to merge 6 commits intoSigma88:masterfrom
seanth wants to merge 6 commits intoSigma88:masterfrom
Conversation
Added a log file message making it clear that the missing file will be created as a stub
Included example settings that are commented out for newly generated Settings.cfg files
Included the ability to check for existing maps, and whether the user wants existing maps overwritten or not. Choosing not to overwrite them speeds load tim up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included ability for user to specify whether existing maps should be overwritter on a per map type basis. This allows the user to leave Cartographer in the mods folder without impacting load time in a significant way if they specify that existing maps should not be overwritten on each game load. This address #22
I also included info written to the first-run generation of the Settings.cfg that provides potential settings. This partly addresses #17 , and can be expanded upon with relative ease.